From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KOV4O-00044G-4c
	for qemu-devel@nongnu.org; Thu, 31 Jul 2008 06:07:40 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KOV4J-00043K-Uv
	for qemu-devel@nongnu.org; Thu, 31 Jul 2008 06:07:36 -0400
Received: from [199.232.76.173] (port=45770 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KOV4J-00042s-GI
	for qemu-devel@nongnu.org; Thu, 31 Jul 2008 06:07:35 -0400
Received: from il.qumranet.com ([212.179.150.194]:31211)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@qumranet.com>) id 1KOV4I-00011L-Sh
	for qemu-devel@nongnu.org; Thu, 31 Jul 2008 06:07:35 -0400
Message-ID: <48918EDF.5000709@qumranet.com>
Date: Thu, 31 Jul 2008 13:07:27 +0300
From: Avi Kivity <avi@qumranet.com>
MIME-Version: 1.0
References: <488D6ECC.2050602@suse.de>
In-Reply-To: <488D6ECC.2050602@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] Save 64-bit of the IA-32e capable sysenter
	MSRs
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

Alexander Graf wrote:
> Hi,
>
> When transitioning from KVM to the qemu userspace, we try to get and 
> push a whole bunch of MSR values, including the SYSENTER ones. While 
> this is basically a good idea, qemu doesn't know anything about 
> SYSENTER on x86_64, which is an additional feature only available on 
> Intel CPUs and thus defines SYSENTER_EIP and SYSENTER_ESP as 32-bit 
> values.
>
> Because we're saving/restoring the SYSENTER values on transitions to 
> userspace and the values in env->cpu only hold 32 bits, they get 
> truncated to 32-bit. The easiest way around this is to widen the 
> fields to 64 bits. This should not disturb the current functionality, 
> but allows us to run 32-bit code on x86_64 using VMX.
>
> As this is KVM specific for now, I'll only CC the qemu mailinglist, 
> but wouldn't encourage qemu to take the patch for now, as it's not 
> necessary when emulating an AMD CPU.
>

Applied, thanks.  I imagine save/restore support needs updating as 
well?  That should go into qemuy btw since maintaining the save/restore 
format across forks isn't possible.

-- 
error compiling committee.c: too many arguments to function