From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KOw1I-0000rP-CE for qemu-devel@nongnu.org; Fri, 01 Aug 2008 10:54:16 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KOw1H-0000qg-CT for qemu-devel@nongnu.org; Fri, 01 Aug 2008 10:54:15 -0400 Received: from [199.232.76.173] (port=52298 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KOw1H-0000qb-7F for qemu-devel@nongnu.org; Fri, 01 Aug 2008 10:54:15 -0400 Received: from wr-out-0506.google.com ([64.233.184.231]:39113) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KOw1G-0003SZ-Ua for qemu-devel@nongnu.org; Fri, 01 Aug 2008 10:54:15 -0400 Received: by wr-out-0506.google.com with SMTP id c46so839089wra.18 for ; Fri, 01 Aug 2008 07:54:14 -0700 (PDT) Message-ID: <48932373.3050206@codemonkey.ws> Date: Fri, 01 Aug 2008 09:53:39 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1217503937.3879.25.camel@frecb07144> In-Reply-To: <1217503937.3879.25.camel@frecb07144> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] qemu: set focus to monitor to ask password if line is multiplexed Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: "qemu-devel@nongnu.org" Laurent Vivier wrote: > This patch allows to display the "Password:" prompt if we use encrypted > disk with "-nographic" option. > > It also modifies management of "-nographic" to not override user's > choices for "-serial", "-parallel" and "-monitor". > > When qemu has to ask a password with "-nographic" with a multiplexed > serial interface, it forces the focus to the monitor and restore > original focus after. > > Regards, > Laurent > Please include a Signed-off-by line in your patch. Otherwise looks good. Regards, Anthony Liguori