From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KOw4n-00036a-Aj
	for qemu-devel@nongnu.org; Fri, 01 Aug 2008 10:57:53 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KOw4m-00035t-Lh
	for qemu-devel@nongnu.org; Fri, 01 Aug 2008 10:57:52 -0400
Received: from [199.232.76.173] (port=50568 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KOw4m-00035n-EY
	for qemu-devel@nongnu.org; Fri, 01 Aug 2008 10:57:52 -0400
Received: from mail-gx0-f23.google.com ([209.85.217.23]:41725)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KOw4m-0004hO-4M
	for qemu-devel@nongnu.org; Fri, 01 Aug 2008 10:57:52 -0400
Received: by gxk4 with SMTP id 4so1311408gxk.10
	for <qemu-devel@nongnu.org>; Fri, 01 Aug 2008 07:57:51 -0700 (PDT)
Message-ID: <4893244A.4040008@codemonkey.ws>
Date: Fri, 01 Aug 2008 09:57:14 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/7] xen: add framebuffer backend driver
References: <1217251078-6591-1-git-send-email-kraxel@redhat.com>	<1217251078-6591-5-git-send-email-kraxel@redhat.com>	<488DD618.5000504@codemonkey.ws>	<16E84423-5C51-4CBA-9D56-04CDE09312DF@web.de>
	<48903B96.6030407@redhat.com>
In-Reply-To: <48903B96.6030407@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>, xen-devel@lists.xensource.com

Gerd Hoffmann wrote:
>   Hi,
>
>   
>>>> +/* A convenient function for munging pixels between different depths */
>>>> +#define
>>>> BLT(SRC_T,DST_T,RSB,GSB,BSB,RDB,GDB,BDB)                        \
>>>> +    for (line = y ; line < (y+h) ; line++) {                \
>>>>         
>
>   
>>> There are similar conversion macros in the VGA code.  I don't know how
>>> practical it would be to reuse them but it's at least worth looking at.
>>>       
>> We created a file hw/pixel_ops.h to share code between vga.c and tcx.c,
>> probably it can be extended to serve Xen as well.
>>     
>
> Uhm, well, it isn't that easy.  Unifying that looks like a big job in
> itself.  pixel_ops.h as-is isn't very helpful for xen-framebuffer.  The
> xen-framebuffer macro isn't very useful to others.
>   

Okay, the xen-framebuffer macros aren't that big so it's not a huge 
deal.  Was worth looking into though.  Thanks!

Regards,

Anthony Liguori

> What IMHO would be most useful is a set of generic conversion functions,
> operating on scanline level, much like the ones created by
> vga_template.h, but without dependencies on vga.c internals.
>
> cheers,
>   Gerd
>
>