From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KOwHO-0001Ep-0e for qemu-devel@nongnu.org; Fri, 01 Aug 2008 11:10:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KOwHM-0001Dp-I6 for qemu-devel@nongnu.org; Fri, 01 Aug 2008 11:10:53 -0400 Received: from [199.232.76.173] (port=52342 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KOwHM-0001Di-9F for qemu-devel@nongnu.org; Fri, 01 Aug 2008 11:10:52 -0400 Received: from mail-gx0-f23.google.com ([209.85.217.23]:38842) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KOwHL-0007Z6-Jw for qemu-devel@nongnu.org; Fri, 01 Aug 2008 11:10:52 -0400 Received: by gxk4 with SMTP id 4so1318731gxk.10 for ; Fri, 01 Aug 2008 08:10:48 -0700 (PDT) Message-ID: <48932751.5040303@codemonkey.ws> Date: Fri, 01 Aug 2008 10:10:09 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] PATCH: v3 Allow control over drive file open mode References: <20080801102949.GN23993@redhat.com> In-Reply-To: <20080801102949.GN23993@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Daniel P. Berrange wrote: > This is version 3 of the patch. > Allowing the user to specify what mode we use to open a file is IMHO not a good interface for a user. A user should only be concerned with how we expose a disk to the guest, not the underlying implementation of how we support this. It has subtle side-effects that a user is not going to expect unless they are intimately familiar with how QEMU is implemented (like snapshotting breaking). Regards, Anthony Liguori