From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix compilation of nbd on Solaris
Date: Fri, 01 Aug 2008 20:58:00 -0500 [thread overview]
Message-ID: <4893BF28.3060909@codemonkey.ws> (raw)
In-Reply-To: <09D57F7C-74FF-408E-846D-05B75F04D7D4@web.de>
Andreas Färber wrote:
> Compilation of QEMU is currently broken on Solaris due to nbd's use of
> _IO and due to network libraries not being linked into qemu-img.
>
> The attached patch adds the appropriate libraries (copied from
> Makefile.target) and includes an additional Sun-specific header for _IO.
>
> With these fixes it compiles okay, on OpenSolaris snv_93 (amd64).
>
> Signed-off-by: Andreas Faerber <andreas.faerber@web.de>
Applied. Thanks.
Your mailer attached the patch as 'application/octet-stream'. In the
future, it would be better it you could also inline the patch or better
yet, attach it as 'text/plain'. That allows for easier commenting for
more complex patches.
Regards,
Anthony Liguori
> Andreas
>
>
>
prev parent reply other threads:[~2008-08-02 1:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-01 21:06 [Qemu-devel] [PATCH] Fix compilation of nbd on Solaris Andreas Färber
2008-08-02 1:58 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4893BF28.3060909@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).