From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KP6OH-0000Q2-K3
	for qemu-devel@nongnu.org; Fri, 01 Aug 2008 21:58:41 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KP6OD-0000O0-29
	for qemu-devel@nongnu.org; Fri, 01 Aug 2008 21:58:41 -0400
Received: from [199.232.76.173] (port=39443 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KP6OC-0000Nt-W3
	for qemu-devel@nongnu.org; Fri, 01 Aug 2008 21:58:37 -0400
Received: from an-out-0708.google.com ([209.85.132.251]:21895)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KP6OC-0003Z6-Hl
	for qemu-devel@nongnu.org; Fri, 01 Aug 2008 21:58:36 -0400
Received: by an-out-0708.google.com with SMTP id d18so367893and.130
	for <qemu-devel@nongnu.org>; Fri, 01 Aug 2008 18:58:34 -0700 (PDT)
Message-ID: <4893BF28.3060909@codemonkey.ws>
Date: Fri, 01 Aug 2008 20:58:00 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Fix compilation of nbd on Solaris
References: <09D57F7C-74FF-408E-846D-05B75F04D7D4@web.de>
In-Reply-To: <09D57F7C-74FF-408E-846D-05B75F04D7D4@web.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Andreas Färber wrote:
> Compilation of QEMU is currently broken on Solaris due to nbd's use of 
> _IO and due to network libraries not being linked into qemu-img.
>
> The attached patch adds the appropriate libraries (copied from 
> Makefile.target) and includes an additional Sun-specific header for _IO.
>
> With these fixes it compiles okay, on OpenSolaris snv_93 (amd64).
>
> Signed-off-by: Andreas Faerber <andreas.faerber@web.de>

Applied.  Thanks.

Your mailer attached the patch as 'application/octet-stream'.  In the 
future, it would be better it you could also inline the patch or better 
yet, attach it as 'text/plain'.  That allows for easier commenting for 
more complex patches.

Regards,

Anthony Liguori

> Andreas
>
>
>