From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KPkpe-0003lU-49
	for qemu-devel@nongnu.org; Sun, 03 Aug 2008 17:09:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KPkpd-0003kD-P4
	for qemu-devel@nongnu.org; Sun, 03 Aug 2008 17:09:37 -0400
Received: from [199.232.76.173] (port=47208 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KPkpd-0003js-AP
	for qemu-devel@nongnu.org; Sun, 03 Aug 2008 17:09:37 -0400
Received: from an-out-0708.google.com ([209.85.132.242]:33564)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KPkpd-0000lV-DI
	for qemu-devel@nongnu.org; Sun, 03 Aug 2008 17:09:37 -0400
Received: by an-out-0708.google.com with SMTP id d18so520132and.130
	for <qemu-devel@nongnu.org>; Sun, 03 Aug 2008 14:09:36 -0700 (PDT)
Message-ID: <48961E6E.90708@codemonkey.ws>
Date: Sun, 03 Aug 2008 16:09:02 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2] Fix compilation of nbd on Windows
References: <20080704092849.5BC0.20F538E7@nsfocus.com>
	<20080704023451.GO7007@networkno.de>
	<20080704115101.5BC9.20F538E7@nsfocus.com>
	<1215160927.3802.4.camel@frecb07144>
	<20080704203231.GB31670@networkno.de>
	<alpine.DEB.1.00.0807042148250.9925@racer>
	<alpine.DEB.1.00.0807042300550.9925@racer>
	<alpine.DEB.1.00.0808022114340.9611@pacific.mpi-cbg.de.mpi-cbg.de>
	<4895E6CC.6040906@codemonkey.ws>
	<alpine.DEB.1.00.0808031924410.9611@pacific.mpi-cbg.de.mpi-cbg.de>
	<4896182A.1040001@codemonkey.ws>
	<alpine.DEB.1.00.0808032256100.9611@pacific.mpi-cbg.de.mpi-cbg.de>
In-Reply-To: <alpine.DEB.1.00.0808032256100.9611@pacific.mpi-cbg.de.mpi-cbg.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Laurent Vivier <Laurent.Vivier@bull.net>, qemu-devel@nongnu.org, chenqing <chenqing@nsfocus.com>

Johannes Schindelin wrote:
> Hi,
>
> On Sun, 3 Aug 2008, Anthony Liguori wrote:
>
>   
>> Johannes Schindelin wrote:
>>
>>     
>>> Indeed, it seems that inet_aton() is defined in slirp/misc.c.  So 
>>> qemu_socket.h is not even the right place for the definition, but 
>>> better than nothing.
>>>       
>> Ugh, I wonder what happens when you do --disable-slirp :-( Do you want 
>> to work up a patch to sanitize all of this or should I?
>>     
>
> You mean to keep my static implementation, but put it in an #ifndef 
> CONFIG_SLIRP, with the #else branch declaring the function?
>
> Sure, I can do it, just tell me if that is what you meant.
>   

It's all pretty messy right now.  I tried to wrap your static 
implementation in a #ifdef QEMU_IMG but then nbd.o gets linked into both 
qemu and qemu-nbd which makes things a pain.  I actually ended up just 
removing the declaration in vl.c and that seemed to work.

Whatever you can do that will make it so we're only using a single 
implementation of inet_aton() will make me happy.

Regards,

Anthony Liguori

> Ciao,
> Dscho
>
>