From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQ4Y2-0006S6-Ac for qemu-devel@nongnu.org; Mon, 04 Aug 2008 14:12:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQ4Xy-0006Iy-Nc for qemu-devel@nongnu.org; Mon, 04 Aug 2008 14:12:45 -0400 Received: from [199.232.76.173] (port=44433 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQ4Xy-0006Ik-HX for qemu-devel@nongnu.org; Mon, 04 Aug 2008 14:12:42 -0400 Received: from mx1.redhat.com ([66.187.233.31]:47706) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KQ4Xy-0005Ib-9S for qemu-devel@nongnu.org; Mon, 04 Aug 2008 14:12:42 -0400 Message-ID: <4897468A.7050009@redhat.com> Date: Mon, 04 Aug 2008 20:12:26 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 7/7] xen: blk & nic configuration via cmd line. References: <1217865045-10722-1-git-send-email-kraxel@redhat.com> <1217865045-10722-8-git-send-email-kraxel@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org Blue Swirl wrote: >> + /* config cleanup hook */ >> + atexit(xen_config_cleanup); > > I'd put this in vl.c, it's not machine specific. It actually is because it cleans up stuff only created for the xenpv machine type. Moving it to vl.c doesn't hurt, I would have to wrap it into "#ifdef CONFIG_XEN" though ... cheers, Gerd -- http://kraxel.fedorapeople.org/xenner/