From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KQ4aa-0001oy-DE
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 14:15:24 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KQ4aY-0001mP-OP
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 14:15:23 -0400
Received: from [199.232.76.173] (port=44479 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KQ4aY-0001lx-Hi
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 14:15:22 -0400
Received: from mx1.redhat.com ([66.187.233.31]:39679)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1KQ4aY-0005i5-9S
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 14:15:22 -0400
Message-ID: <4897472A.1070100@redhat.com>
Date: Mon, 04 Aug 2008 20:15:06 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/7] xen: add console backend driver.
References: <1217865045-10722-1-git-send-email-kraxel@redhat.com>	
	<1217865045-10722-4-git-send-email-kraxel@redhat.com>
	<f43fc5580808040952o7dc14337i864978b0df2623f3@mail.gmail.com>
In-Reply-To: <f43fc5580808040952o7dc14337i864978b0df2623f3@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org

Blue Swirl wrote:
> On 8/4/08, Gerd Hoffmann <kraxel@redhat.com> wrote:
>>  +       buffer->data = realloc(buffer->data, buffer->capacity);
> 
> On Qemu, instead of malloc,  qemu_malloc should be used to allocate
> memory. Though there isn't qemu_realloc.

Should I add qemu_realloc then?

>>  +    if (!type || 0 != strcmp(type, "ioemu")) {
> 
> Shouldn't this be "qemu"?

No, "ioemu" is correct.  xend writes that value into xenstore.

cheers,
  Gerd

-- 
http://kraxel.fedorapeople.org/xenner/