From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KQ4g3-0005Gt-73
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 14:21:03 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KQ4g1-0005Fe-Rs
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 14:21:02 -0400
Received: from [199.232.76.173] (port=58440 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KQ4g1-0005FW-KC
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 14:21:01 -0400
Received: from mx1.redhat.com ([66.187.233.31]:57346)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1KQ4g1-0006a5-Bg
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 14:21:01 -0400
Message-ID: <48974869.7020209@redhat.com>
Date: Mon, 04 Aug 2008 20:20:25 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/7] xen: add framebuffer backend driver
References: <1217865045-10722-1-git-send-email-kraxel@redhat.com>	
	<1217865045-10722-5-git-send-email-kraxel@redhat.com>
	<f43fc5580808041009g727f9f59gff94e27decfe2d25@mail.gmail.com>
In-Reply-To: <f43fc5580808041009g727f9f59gff94e27decfe2d25@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org

Blue Swirl wrote:
> On 8/4/08, Gerd Hoffmann <kraxel@redhat.com> wrote:
>>  +const unsigned char atkbd_set2_keycode[512] = {
> 
> Missing "static"?

Yep, I'll fix it up.

>>  +       for (i = 0; i < 128; i++) {
>>  +           scancode2linux[i] = atkbd_set2_keycode[atkbd_unxlate_table[i]];
>>  +           scancode2linux[i | 0x80] =
>>  +               atkbd_set2_keycode[atkbd_unxlate_table[i] | 0x80];
>>  +       }
> 
> Can't these table be calculated so that this initial run-time lookup
> is not needed?

Should be doable, yes.

> The framebuffer does not use dirty memory detection. Is this
> intentional? I understand that in Xen that's not possible.

The guest frontend driver does that and sends the info to the backend
driver (XENFB_TYPE_UPDATE messages).

cheers,
  Gerd

-- 
http://kraxel.fedorapeople.org/xenner/