From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQMpG-0005fx-6v for qemu-devel@nongnu.org; Tue, 05 Aug 2008 09:43:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQMpE-0005fU-FR for qemu-devel@nongnu.org; Tue, 05 Aug 2008 09:43:45 -0400 Received: from [199.232.76.173] (port=34812 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQMpE-0005fR-CG for qemu-devel@nongnu.org; Tue, 05 Aug 2008 09:43:44 -0400 Received: from mx1.redhat.com ([66.187.233.31]:47038) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KQMpD-0003Ef-U0 for qemu-devel@nongnu.org; Tue, 05 Aug 2008 09:43:44 -0400 Message-ID: <4898590B.50300@redhat.com> Date: Tue, 05 Aug 2008 15:43:39 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/3]: Add -uuid option to Qemu References: <488DC8BD.8080100@redhat.com> In-Reply-To: <488DC8BD.8080100@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: gleb@qumranet.com Chris Lalancette wrote: > As suggested by Anthony, this patch and the next one were split apart. This > patch just adds the basic plumbing to qemu to be able to set the uuid on the > command-line, and retrieve the information via "info uuid". What is the point of CONFIG_UUID and the libuuid test in that patch? I can't see any dependency on it in the source code. IMHO the -uuid switch should be present unconditionally. Oh, and I'd like to see a cleaned up patch merged soon, even if the qemu <=> bochs bios communication path isn't worked out yet. I need the uuid for xen support too. cheers, Gerd PS: Anyone knows a way to make thunderbird include inline attachments in the reply, so I can comment the patches better? -- http://kraxel.fedorapeople.org/xenner/