Re: [Qemu-devel] [PATCH 2/3]: Add -uuid option to Qemu

[Chris Lalancette <clalance@redhat.com>]

Gerd Hoffmann wrote:
> Chris Lalancette wrote:
>> As suggested by Anthony, this patch and the next one were split apart.  This
>> patch just adds the basic plumbing to qemu to be able to set the uuid on the
>> command-line, and retrieve the information via "info uuid".
> 
> What is the point of CONFIG_UUID and the libuuid test in that patch?
> I can't see any dependency on it in the source code.  IMHO the -uuid
> switch should be present unconditionally.

Hm, CONFIG_UUID is used, for instance, to control whether we output the -uuid
part of the help string.  There are other uses in the patch as well.

I think the problem with including it unconditionally is that it drags in the
uuid library, which may or may not always be available.  Now, as far as I can
tell, that library comes with e2fsprogs, so basically any Linux system will have
it, but that might not be the case for other OS's.

Chris Lalancette