From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KQN0h-0005Ww-55
	for qemu-devel@nongnu.org; Tue, 05 Aug 2008 09:55:35 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KQN0f-0005VY-8d
	for qemu-devel@nongnu.org; Tue, 05 Aug 2008 09:55:34 -0400
Received: from [199.232.76.173] (port=48079 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KQN0f-0005VO-2p
	for qemu-devel@nongnu.org; Tue, 05 Aug 2008 09:55:33 -0400
Received: from mx1.redhat.com ([66.187.233.31]:41380)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <clalance@redhat.com>) id 1KQN0e-0006TA-M2
	for qemu-devel@nongnu.org; Tue, 05 Aug 2008 09:55:32 -0400
Message-ID: <48985B63.8060506@redhat.com>
Date: Tue, 05 Aug 2008 15:53:39 +0200
From: Chris Lalancette <clalance@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/3]: Add -uuid option to Qemu
References: <488DC8BD.8080100@redhat.com> <4898590B.50300@redhat.com>
In-Reply-To: <4898590B.50300@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: gleb@qumranet.com

Gerd Hoffmann wrote:
> Chris Lalancette wrote:
>> As suggested by Anthony, this patch and the next one were split apart.  This
>> patch just adds the basic plumbing to qemu to be able to set the uuid on the
>> command-line, and retrieve the information via "info uuid".
> 
> What is the point of CONFIG_UUID and the libuuid test in that patch?
> I can't see any dependency on it in the source code.  IMHO the -uuid
> switch should be present unconditionally.

Hm, CONFIG_UUID is used, for instance, to control whether we output the -uuid
part of the help string.  There are other uses in the patch as well.

I think the problem with including it unconditionally is that it drags in the
uuid library, which may or may not always be available.  Now, as far as I can
tell, that library comes with e2fsprogs, so basically any Linux system will have
it, but that might not be the case for other OS's.

Chris Lalancette