From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQNb9-0000O8-Vl for qemu-devel@nongnu.org; Tue, 05 Aug 2008 10:33:16 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQNb8-0000NO-W4 for qemu-devel@nongnu.org; Tue, 05 Aug 2008 10:33:15 -0400 Received: from [199.232.76.173] (port=49706 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQNb8-0000NE-RP for qemu-devel@nongnu.org; Tue, 05 Aug 2008 10:33:14 -0400 Received: from mx1.redhat.com ([66.187.233.31]:51150) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KQNb8-0006iu-JB for qemu-devel@nongnu.org; Tue, 05 Aug 2008 10:33:14 -0400 Message-ID: <48986496.90202@redhat.com> Date: Tue, 05 Aug 2008 16:32:54 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/3]: Add -uuid option to Qemu References: <488DC8BD.8080100@redhat.com> <4898590B.50300@redhat.com> <48985B63.8060506@redhat.com> In-Reply-To: <48985B63.8060506@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: gleb@qumranet.com Chris Lalancette wrote: > Gerd Hoffmann wrote: >> Chris Lalancette wrote: >>> As suggested by Anthony, this patch and the next one were split apart. This >>> patch just adds the basic plumbing to qemu to be able to set the uuid on the >>> command-line, and retrieve the information via "info uuid". >> What is the point of CONFIG_UUID and the libuuid test in that patch? >> I can't see any dependency on it in the source code. IMHO the -uuid >> switch should be present unconditionally. > > Hm, CONFIG_UUID is used, for instance, to control whether we output the -uuid > part of the help string. There are other uses in the patch as well. Sure. > I think the problem with including it unconditionally is that it drags in the > uuid library, which may or may not always be available. Does it? As far I can see none of the bits wrapped into #ifdef CONFIG_UUID actually calls that library. If you wanna do stuff like generating a uuid in case none was specified on the command line, _then_ you'll need libuuid and those parts should be compiled conditionally. I don't see the point for the -uuid cmd line switch though. Gleb's patches seem to have organized things this way according to his reply (didn't check list archive). cheers, Gerd -- http://kraxel.fedorapeople.org/xenner/