From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KQNe0-0002rN-58
	for qemu-devel@nongnu.org; Tue, 05 Aug 2008 10:36:12 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KQNdy-0002pE-EX
	for qemu-devel@nongnu.org; Tue, 05 Aug 2008 10:36:11 -0400
Received: from [199.232.76.173] (port=49872 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KQNdy-0002ow-8H
	for qemu-devel@nongnu.org; Tue, 05 Aug 2008 10:36:10 -0400
Received: from ns2.suse.de ([195.135.220.15]:47667 helo=mx2.suse.de)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <kwolf@suse.de>) id 1KQNdx-0007MN-Tc
	for qemu-devel@nongnu.org; Tue, 05 Aug 2008 10:36:10 -0400
Message-ID: <48986507.8020305@suse.de>
Date: Tue, 05 Aug 2008 16:34:47 +0200
From: Kevin Wolf <kwolf@suse.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [patch 1/5][v2] Extract code
	from	get_cluster_offset()
References: <20080729141352.573798859@bull.net>	
	<20080729141447.164763280@bull.net> <48986078.6060701@suse.de>
	<1217946507.3865.24.camel@frecb07144>
In-Reply-To: <1217946507.3865.24.camel@frecb07144>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <Laurent.Vivier@bull.net>
Cc: qemu-devel@nongnu.org

Laurent Vivier schrieb:
> It is a cut&paste... so I don't know what it is really doing and I don't
> want to modify something that has no direct link to the goal I reach...
> even a variable name.

I know and I certainly don't want you to include this change in this
patch as it would make the patch even worse to read. This would be more
of a change for some [patch 6/5] with the accumulated minor cleanups.

> I'm currently testing these patches with encrypted disk and compressed
> disk, and I've found a bug with encrypted one. I'll repost patches soon.

So the segfault when saving a snapshot with encrypted disks is gone? ;-)

Kevin