From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KQOgJ-0006sv-6E
	for qemu-devel@nongnu.org; Tue, 05 Aug 2008 11:42:39 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KQOgH-0006sU-P8
	for qemu-devel@nongnu.org; Tue, 05 Aug 2008 11:42:38 -0400
Received: from [199.232.76.173] (port=44906 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KQOgH-0006sM-DA
	for qemu-devel@nongnu.org; Tue, 05 Aug 2008 11:42:37 -0400
Received: from cantor2.suse.de ([195.135.220.15]:52546 helo=mx2.suse.de)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <kwolf@suse.de>) id 1KQOgG-0002lo-Qp
	for qemu-devel@nongnu.org; Tue, 05 Aug 2008 11:42:37 -0400
Message-ID: <4898749C.4020800@suse.de>
Date: Tue, 05 Aug 2008 17:41:16 +0200
From: Kevin Wolf <kwolf@suse.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [patch 2/5][v2] Divide get_cluster_offset()
References: <20080729141352.573798859@bull.net>	
	<20080729141447.315247848@bull.net> <48986E34.203@suse.de>
	<1217949910.3865.31.camel@frecb07144>
In-Reply-To: <1217949910.3865.31.camel@frecb07144>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <Laurent.Vivier@bull.net>
Cc: qemu-devel@nongnu.org

Laurent Vivier schrieb:
> Le mardi 05 ao=C3=BBt 2008 =C3=A0 17:13 +0200, Kevin Wolf a =C3=A9crit =
:
> [...]
>> Why are you moving that code around? I don't think it's needed for the
>> get_cluster_offset/allocate_cluster_offset split. You're just
>> duplicating the write and return.
>=20
> You're right but doing this here allows to clearly split compressed cas=
e
> and normal case. It is doing for following patches.

Yes, I've noticed that now by myself. Seems I have to look at the
complete patch series until I can tell if this makes sense. ;-)

For now, I assume you have good reasons to do it this way. So take it as
an Ack for this patch as it is.

Kevin