From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQYm5-0003mb-BV for qemu-devel@nongnu.org; Tue, 05 Aug 2008 22:29:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQYm3-0003jh-I3 for qemu-devel@nongnu.org; Tue, 05 Aug 2008 22:29:16 -0400 Received: from [199.232.76.173] (port=52742 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQYm3-0003jX-Bj for qemu-devel@nongnu.org; Tue, 05 Aug 2008 22:29:15 -0400 Received: from py-out-1112.google.com ([64.233.166.178]:49035) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KQYm3-0000uP-EL for qemu-devel@nongnu.org; Tue, 05 Aug 2008 22:29:15 -0400 Received: by py-out-1112.google.com with SMTP id p76so1520077pyb.10 for ; Tue, 05 Aug 2008 19:29:14 -0700 (PDT) Message-ID: <48990C49.4010102@codemonkey.ws> Date: Tue, 05 Aug 2008 21:28:25 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] upgrading emulated UART to 16550A References: <48985284.9060001@eu.citrix.com> In-Reply-To: <48985284.9060001@eu.citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Ian Jackson Stefano Stabellini wrote: > This patch upgrades the emulated UART to 16550A, the code comes from > xen-unstable. > The main improvement was introduced with the following patch and > subsequent email thread: > > http://lists.xensource.com/archives/html/xen-devel/2007-12/msg00129.html > Very nice. Improving serial port emulation is on my list of TODO items so I'm glad to see this :-) > I only made few changes to use qemu_get_clock instead of > clock_gettime, as Anthony suggested a little while ago. > I'll do a more thorough review on your next submission but one thing I wanted to point out, is that a lot of machine types rely on the serial emulation. While this patch has been tested in Xen, presumably, we need to make sure to do a fair bit of testing with non-x86 targets. Regards, Anthony Liguori > Signed-off-by: Stefano Stabellini > > --- >