From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] only check RCTL_EN in e1000_can_receive()
Date: Wed, 06 Aug 2008 09:13:15 -0500 [thread overview]
Message-ID: <4899B17B.503@codemonkey.ws> (raw)
In-Reply-To: <g7adi4$as5$1@ger.gmane.org>
Charles Duffy wrote:
> e1000_receive() has code to raise a receive overflow interrupt when
> the receive buffer head and tail match. However, with the present
> implementation of e1000_can_receive(), this code is unreachable -- and
> etherboot breaks as a result.
>
> The attached quick-and-dirty patch fixes etherboot for e1000, and does
> not appear to break post-boot functionality.
While this is a legitimate bug, it's probably only present in KVM or
when using the slirp rate limiting. Right in QEMU, a can_receive
handler for a network card is largely ignored whereas in KVM, it is used
to throttle receive for the tap device.
Nonetheless, the correct behaviour is to raise an interrupt when a
packet could be received but no buffers are available so I've applied
this patch. Thanks.
Regards,
Anthony Liguori
prev parent reply other threads:[~2008-08-06 14:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 20:35 [Qemu-devel] [PATCH] only check RCTL_EN in e1000_can_receive() Charles Duffy
2008-08-06 14:13 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4899B17B.503@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).