From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KR7Jo-0003Q8-93 for qemu-devel@nongnu.org; Thu, 07 Aug 2008 11:22:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KR7Jk-0003I9-Mm for qemu-devel@nongnu.org; Thu, 07 Aug 2008 11:22:23 -0400 Received: from [199.232.76.173] (port=45272 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KR7Jk-0003Hv-DS for qemu-devel@nongnu.org; Thu, 07 Aug 2008 11:22:20 -0400 Received: from mx1.redhat.com ([66.187.233.31]:41405) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KR7Jk-0007fv-3i for qemu-devel@nongnu.org; Thu, 07 Aug 2008 11:22:20 -0400 Message-ID: <489B1316.1030109@redhat.com> Date: Thu, 07 Aug 2008 17:21:58 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Xen-devel] Re: [Qemu-devel] [PATCH 0/7] merge some xen bits into qemu References: <20080805150328.GT4478@implementation.uk.xensource.com> <20080806102338.GA4448@implementation.uk.xensource.com> <20080806125055.GG4448@implementation.uk.xensource.com> <4899AD19.8060606@redhat.com> <20080806140132.GL4448@implementation.uk.xensource.com> <4899B06F.2090101@redhat.com> <20080806142526.GN4448@implementation.uk.xensource.com> <20080806221047.GE4486@implementation> <489AA532.7040006@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: xen-devel@lists.xensource.com, Ian Jackson , Markus Armbruster , qemu-devel@nongnu.org, Samuel Thibault Blue Swirl wrote: >> http://kraxel.fedorapeople.org/patches/qemu-xen/ > 0004-xenpv-groundwork.patch > > You dropped nodisk_ok support from vl.c. Oh, there are *two* patchsets: http://kraxel.fedorapeople.org/patches/qemu-upstream/ http://kraxel.fedorapeople.org/patches/qemu-xen/ The first also includes some not-yet submitted work-in-progress bits. It is against upstream qemu svn. The second is against xen's qemu fork, so the xen-related changes can get a test-drive there. Especially the vl.c changes are very different in the two patch sets because xen's vl.c looks very different (lot of CONFIG_DM conditional code) and because I don't want to break the command line interface for now to not break xend's expectations. That doesn't mean that the nodisk_ok got lost. It is only in the first patchset though. > 0005-xen-backend-core.patch > > container_of could go to osdep.h. Will do. > 0006-xen-console-backend.patch > > Not your fault, but a lot of places (at least ps2.c and > slavio_serial.c) define some kind of ring buffers. Maybe these could > be consolidated some time. Will have a look if I find some time. > 0007-xen-framebuffer-backend.patch > > After you optimized scancode2linux[], it looks like > atkbd_set2_keycode[] and atkbd_unxlate_table[] are not needed. Indeed. Think I just ifdef them out and leave them in there as documentation. cheers, Gerd -- http://kraxel.fedorapeople.org/xenner/