From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KRB7w-0003Vk-4u
	for qemu-devel@nongnu.org; Thu, 07 Aug 2008 15:26:24 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KRB7u-0003Td-FG
	for qemu-devel@nongnu.org; Thu, 07 Aug 2008 15:26:23 -0400
Received: from [199.232.76.173] (port=33686 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KRB7u-0003TP-9p
	for qemu-devel@nongnu.org; Thu, 07 Aug 2008 15:26:22 -0400
Received: from mail.windriver.com ([147.11.1.11]:45110 helo=mail.wrs.com)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jason.wessel@windriver.com>) id 1KRB7u-0002JI-6L
	for qemu-devel@nongnu.org; Thu, 07 Aug 2008 15:26:22 -0400
Received: from ALA-MAIL03.corp.ad.wrs.com (ala-mail03 [147.11.57.144])
	by mail.wrs.com (8.13.6/8.13.6) with ESMTP id m77JQK2k021351
	for <qemu-devel@nongnu.org>; Thu, 7 Aug 2008 12:26:20 -0700 (PDT)
Message-ID: <489B4C60.70502@windriver.com>
Date: Thu, 07 Aug 2008 14:26:24 -0500
From: Jason Wessel <jason.wessel@windriver.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] upgrading emulated UART to 16550A
References: <489B3278.4080001@eu.citrix.com>
In-Reply-To: <489B3278.4080001@eu.citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Stefano Stabellini wrote:
> This is an improved version of the UART 16550A emulation patch.
> The changes compared to previous version are:
>
> - no token bucket anymore;
>
> - fixed a small bug handling IRQs; this was the problem that prevented
> kgdb to work over the serial (thanks to Jason Wessel for the help
> spotting and reproducing this bug).
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
>   

Looks good now from my perspective for the regression tests I have. 
Thanks for fixing the problem.  I can confirm that polled mode and
interrupt driven mode work correctly on 2.6 Linux kernels for the
x86_64, i386, and mips BE/LE emulations.

Acked-by: Jason Wessel <jason.wessel@windriver.com>


Jason.