From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KRTfk-0002C1-SZ
	for qemu-devel@nongnu.org; Fri, 08 Aug 2008 11:14:32 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KRTfk-0002Aq-8N
	for qemu-devel@nongnu.org; Fri, 08 Aug 2008 11:14:32 -0400
Received: from [199.232.76.173] (port=44926 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KRTfk-0002Ah-0L
	for qemu-devel@nongnu.org; Fri, 08 Aug 2008 11:14:32 -0400
Received: from smtp.ctxuk.citrix.com ([62.200.22.115]:6409
	helo=SMTP.EU.CITRIX.COM)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Stefano.Stabellini@eu.citrix.com>)
	id 1KRTfj-0007aD-LM
	for qemu-devel@nongnu.org; Fri, 08 Aug 2008 11:14:31 -0400
Message-ID: <489C632C.1090407@eu.citrix.com>
Date: Fri, 08 Aug 2008 16:15:56 +0100
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] upgrading emulated UART to 16550A
References: <489C5E53.3020208@eu.citrix.com>
In-Reply-To: <489C5E53.3020208@eu.citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Stefano Stabellini wrote:

> Another improved version of the UART 16550A emulation patch.
> This one takes into account all the comments made by Anthony.
> The main changes are:
> 
> - many many style fixes;
> 
> - savevm version number increased;
> 
> - not including termios.h and sys/ioctl.h anymore, declaring static
> constants in qemu-char.h instead;


I have just realized I haven't fully solved the compatibility problem
because I didn't converted the constants defined in qemu-char.h into
termios constant before calling ioctl.
A new patch is coming soon.