From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KRt9W-0000o9-Se for qemu-devel@nongnu.org; Sat, 09 Aug 2008 14:26:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KRt9V-0000nV-2O for qemu-devel@nongnu.org; Sat, 09 Aug 2008 14:26:58 -0400 Received: from [199.232.76.173] (port=42350 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KRt9U-0000nM-RJ for qemu-devel@nongnu.org; Sat, 09 Aug 2008 14:26:56 -0400 Received: from mail-gx0-f23.google.com ([209.85.217.23]:37929) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KRt9T-0005Su-4a for qemu-devel@nongnu.org; Sat, 09 Aug 2008 14:26:55 -0400 Received: by gxk4 with SMTP id 4so6205139gxk.10 for ; Sat, 09 Aug 2008 11:26:54 -0700 (PDT) Message-ID: <489DE148.2000200@codemonkey.ws> Date: Sat, 09 Aug 2008 13:26:16 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] upgrading emulated UART to 16550A References: <489C7B19.5030905@eu.citrix.com> In-Reply-To: <489C7B19.5030905@eu.citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hi Stefano, Stefano Stabellini wrote: > Same comments as before, but this time the cross-platform compatibility > code should be correct. > More opinions on this are welcome. > I think the patch looks good. What targets/guests have you tested with? Have you tested any non-x86 targets? Regards, Anthony Liguori > Signed-off-by: Stefano Stabellini >