From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KSWnk-0004Dm-2t
	for qemu-devel@nongnu.org; Mon, 11 Aug 2008 08:47:08 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KSWni-0004DZ-NU
	for qemu-devel@nongnu.org; Mon, 11 Aug 2008 08:47:07 -0400
Received: from [199.232.76.173] (port=47744 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KSWni-0004DW-EU
	for qemu-devel@nongnu.org; Mon, 11 Aug 2008 08:47:06 -0400
Received: from mx1.redhat.com ([66.187.233.31]:57733)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1KSWnh-0002aN-Bu
	for qemu-devel@nongnu.org; Mon, 11 Aug 2008 08:47:06 -0400
Message-ID: <48A034B9.3010906@redhat.com>
Date: Mon, 11 Aug 2008 14:46:49 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Xen-devel] Re: [Qemu-devel] [PATCH 0/7] merge some xen bits
	into qemu
References: <20080805150328.GT4478@implementation.uk.xensource.com>	
	<20080806125055.GG4448@implementation.uk.xensource.com>	
	<4899AD19.8060606@redhat.com>	
	<20080806140132.GL4448@implementation.uk.xensource.com>	
	<4899B06F.2090101@redhat.com>	
	<20080806142526.GN4448@implementation.uk.xensource.com>	
	<20080806221047.GE4486@implementation>
	<489AA532.7040006@redhat.com>	
	<f43fc5580808070806g19997fedxbf67fdf9d2060e4b@mail.gmail.com>	
	<489B1316.1030109@redhat.com>
	<f43fc5580808080824v5c7046c3x3542c14bc39d2f83@mail.gmail.com>
In-Reply-To: <f43fc5580808080824v5c7046c3x3542c14bc39d2f83@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: xen-devel@lists.xensource.com, Ian Jackson <Ian.Jackson@eu.citrix.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Samuel Thibault <samuel.thibault@eu.citrix.com>

Blue Swirl wrote:
> I extracted a small patch that only introduces the nodisk_ok part.
> Anybody unhappy if I commit it?

How about converting all struct fields to C99 initializers in
hw/sun4*.c?  Mixing the two styles looks quite odd.

cheers,
  Gerd

-- 
http://kraxel.fedorapeople.org/xenner/