From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KSaYz-0008KN-Cr for qemu-devel@nongnu.org; Mon, 11 Aug 2008 12:48:09 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KSaYs-0008Co-KB for qemu-devel@nongnu.org; Mon, 11 Aug 2008 12:48:08 -0400 Received: from [199.232.76.173] (port=43696 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KSaYs-0008Cd-DT for qemu-devel@nongnu.org; Mon, 11 Aug 2008 12:48:02 -0400 Received: from qb-out-1314.google.com ([72.14.204.168]:43291) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KSaYr-0003tQ-UN for qemu-devel@nongnu.org; Mon, 11 Aug 2008 12:48:02 -0400 Received: by qb-out-1314.google.com with SMTP id c6so2294668qbc.8 for ; Mon, 11 Aug 2008 09:47:54 -0700 (PDT) Message-ID: <48A06D07.60103@codemonkey.ws> Date: Mon, 11 Aug 2008 11:47:03 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFC, PATCH] Add -Wstrict-prototypes, maybe later -Wmissing-prototypes References: <489DE0C7.9000505@codemonkey.ws> <48A04ACD.5090900@codemonkey.ws> <48A05150.2040405@qumranet.com> <48A0533A.9020707@codemonkey.ws> <48A06B12.5000701@qumranet.com> In-Reply-To: <48A06B12.5000701@qumranet.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Avi Kivity wrote: > > You lose the switch(nb_args) in monitor_handle_command() so it comes > out even. You don't need to cast anything -- though you do need to > change all the callbacks to accept an argument array. And to either explicitly cast each argument or explicitly parse each argument. It touches quite a bit of places in the code and makes the callbacks quite a bit more complicated. Using a void * is a one line change and works on all modern systems. Seems like a winner to me :-) Regards, Anthony Liguori