From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KSd3l-0001pO-Go
	for qemu-devel@nongnu.org; Mon, 11 Aug 2008 15:28:05 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KSd3f-0001hz-7p
	for qemu-devel@nongnu.org; Mon, 11 Aug 2008 15:28:01 -0400
Received: from [199.232.76.173] (port=45123 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KSd3d-0001fN-Ij
	for qemu-devel@nongnu.org; Mon, 11 Aug 2008 15:27:57 -0400
Received: from wr-out-0506.google.com ([64.233.184.228]:12696)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KSd3d-0007Lx-7X
	for qemu-devel@nongnu.org; Mon, 11 Aug 2008 15:27:57 -0400
Received: by wr-out-0506.google.com with SMTP id c46so1740901wra.18
	for <qemu-devel@nongnu.org>; Mon, 11 Aug 2008 12:27:56 -0700 (PDT)
Message-ID: <48A09296.2040406@codemonkey.ws>
Date: Mon, 11 Aug 2008 14:27:18 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 01/11] Handle terminating signals.
References: <1218457970-11707-1-git-send-email-kraxel@redhat.com>
	<1218457970-11707-2-git-send-email-kraxel@redhat.com>
In-Reply-To: <1218457970-11707-2-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: xen-devel@lists.xensource.com, Gerd Hoffmann <kraxel@redhat.com>

Gerd Hoffmann wrote:
> diff --git a/curses.c b/curses.c
> index 87aa9b3..03580fb 100644
> --- a/curses.c
> +++ b/curses.c
> @@ -346,8 +346,6 @@ void curses_display_init(DisplayState *ds, int full_screen)
>      atexit(curses_atexit);
>  
>  #ifndef _WIN32
> -    signal(SIGINT, SIG_DFL);
> -    signal(SIGQUIT, SIG_DFL);
>  #if defined(SIGWINCH) && defined(KEY_RESIZE)
>      /* some curses implementations provide a handler, but we
>       * want to be sure this is handled regardless of the library */
> diff --git a/sdl.c b/sdl.c
> index 0edc4a0..84a9d6d 100644
> --- a/sdl.c
> +++ b/sdl.c
> @@ -476,10 +476,8 @@ static void sdl_refresh(DisplayState *ds)
>                  sdl_process_key(&ev->key);
>              break;
>          case SDL_QUIT:
> -            if (!no_quit) {
> +            if (!no_quit)
>                  qemu_system_shutdown_request();
> -                vm_start();	/* In case we're paused */
>   

I'm curious why this is no longer needed?