From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Handle terminating signals.
Date: Mon, 11 Aug 2008 21:46:42 +0200 [thread overview]
Message-ID: <48A09722.3060106@redhat.com> (raw)
In-Reply-To: <18592.28256.85302.846876@mariner.uk.xensource.com>
Ian Jackson wrote:
> Gerd Hoffmann writes ("[Qemu-devel] [PATCH] Handle terminating signals."):
>> This patch makes qemu handle signals better. For normal signals
>> (SIGINT, SIGTERM & friends) it just sets the request_shutdown flag,
>> making the main_loop exit and qemu taking the usual exit route, with
>> atexit handlers being called and so on, instead of qemu just being
>> killed by the signal.
>>
>> + sigaction(SIGINT, &act, NULL);
>> + sigaction(SIGHUP, &act, NULL);
>> + sigaction(SIGTERM, &act, NULL);
>> + sigaction(SIGQUIT, &act, NULL);
>
> SIGQUIT should not be in this list. QUIT does not mean `please
> terminate'. It's a signal used for debugging purposes and usually
> means `please pretend this program took a SEGV'. The default action
> is to die and dump core, and this should be preserved.
Ok, we could take the SIGSEGV cleanup route, then call abort(). That
should come close enougth. Does that sound ok?
cheers,
Gerd
--
http://kraxel.fedorapeople.org/xenner/
next prev parent reply other threads:[~2008-08-11 19:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 11:48 [Qemu-devel] [PATCH] Handle terminating signals Gerd Hoffmann
2008-08-11 16:52 ` Ian Jackson
2008-08-11 19:46 ` Gerd Hoffmann [this message]
2008-08-12 10:05 ` Ian Jackson
2008-08-12 11:46 ` Stefano Stabellini
2008-08-12 18:29 ` Gerd Hoffmann
2008-08-12 19:29 ` M. Warner Losh
2008-08-12 19:42 ` Gerd Hoffmann
2008-08-12 19:49 ` Anthony Liguori
2008-08-13 8:27 ` Daniel P. Berrange
2008-08-13 13:29 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A09722.3060106@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).