From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KSdRr-00005M-BQ for qemu-devel@nongnu.org; Mon, 11 Aug 2008 15:52:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KSdRq-0008VG-3K for qemu-devel@nongnu.org; Mon, 11 Aug 2008 15:52:58 -0400 Received: from [199.232.76.173] (port=46620 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KSdRp-0008Uz-Ql for qemu-devel@nongnu.org; Mon, 11 Aug 2008 15:52:57 -0400 Received: from mx1.redhat.com ([66.187.233.31]:41085) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KSdRp-0002k5-MA for qemu-devel@nongnu.org; Mon, 11 Aug 2008 15:52:57 -0400 Message-ID: <48A09896.60807@redhat.com> Date: Mon, 11 Aug 2008 21:52:54 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 01/11] Handle terminating signals. References: <1218457970-11707-1-git-send-email-kraxel@redhat.com> <1218457970-11707-2-git-send-email-kraxel@redhat.com> <48A09296.2040406@codemonkey.ws> In-Reply-To: <48A09296.2040406@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: xen-devel@lists.xensource.com Anthony Liguori wrote: >> --- a/sdl.c >> +++ b/sdl.c >> @@ -476,10 +476,8 @@ static void sdl_refresh(DisplayState *ds) >> sdl_process_key(&ev->key); >> break; >> case SDL_QUIT: >> - if (!no_quit) { >> + if (!no_quit) >> qemu_system_shutdown_request(); >> - vm_start(); /* In case we're paused */ >> > > I'm curious why this is no longer needed? To avoid calling vm_start() from the signal handler main_loop() got an additional check so qemu_system_shutdown_request() works even when the vm is in stopped state. [ Hmm, cut&paste -> changelog I guess ... ] cheers, Gerd -- http://kraxel.fedorapeople.org/xenner/