[Qemu-devel] [PATCH] fix serial IIR read [Was: SVN Rev 4994 (now) Won't install Windows XP]

[Qemu-devel] [PATCH] fix serial IIR read [Was: SVN Rev 4994 (now) Won't install Windows XP]

[Samuel Thibault]

Brad Campbell, le Tue 12 Aug 2008 11:02:39 +0400, a écrit :
> qemu -hda xptest.img -cdrom XP-corp-sp2.iso -boot d -m 256 -no-kqemu 
> -no-reboot -no-acpi
> 
> It just hangs at "Setup is starting Windows".

The patch below fixes it for me.

Samuel



serial: Always update iir, even when ier is empty.

Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>

Index: hw/serial.c
===================================================================
--- hw/serial.c	(révision 4994)
+++ hw/serial.c	(copie de travail)
@@ -189,11 +189,6 @@
 {
     uint8_t tmp_iir = UART_IIR_NO_INT;
 
-    if (!s->ier) {
-        qemu_irq_lower(s->irq);
-        return;
-    }
-
     if ((s->ier & UART_IER_RLSI) && (s->lsr & UART_LSR_INT_ANY)) {
         tmp_iir = UART_IIR_RLSI;
     } else if (s->timeout_ipending) {

Re: [Qemu-devel] [PATCH] fix serial IIR read [Was: SVN Rev 4994 (now) Won't install Windows XP]

[Stefano Stabellini]

Samuel Thibault wrote:

> Brad Campbell, le Tue 12 Aug 2008 11:02:39 +0400, a écrit :
>> qemu -hda xptest.img -cdrom XP-corp-sp2.iso -boot d -m 256 -no-kqemu 
>> -no-reboot -no-acpi
>>
>> It just hangs at "Setup is starting Windows".
> 
> The patch below fixes it for me.
> 
> Samuel
> 
> 
> 
> serial: Always update iir, even when ier is empty.
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>

Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Re: [Qemu-devel] [PATCH] fix serial IIR read [Was: SVN Rev 4994 (now) Won't install Windows XP]

[Brad Campbell]

Samuel Thibault wrote:
> Brad Campbell, le Tue 12 Aug 2008 11:02:39 +0400, a écrit :
>> qemu -hda xptest.img -cdrom XP-corp-sp2.iso -boot d -m 256 -no-kqemu 
>> -no-reboot -no-acpi
>>
>> It just hangs at "Setup is starting Windows".
> 
> The patch below fixes it for me.

Confirmed here. Thanks :)

Brad
-- 
Dolphins are so intelligent that within a few weeks they can
train Americans to stand at the edge of the pool and throw them
fish.

Re: [Qemu-devel] [PATCH] fix serial IIR read [Was: SVN Rev 4994 (now) Won't install Windows XP]

[Jason Wessel]

Stefano Stabellini wrote:
> Samuel Thibault wrote:
>
>   
>> Brad Campbell, le Tue 12 Aug 2008 11:02:39 +0400, a écrit :
>>     
>>> qemu -hda xptest.img -cdrom XP-corp-sp2.iso -boot d -m 256 -no-kqemu 
>>> -no-reboot -no-acpi
>>>
>>> It just hangs at "Setup is starting Windows".
>>>       
>> The patch below fixes it for me.
>>
>> Samuel
>>
>>
>>
>> serial: Always update iir, even when ier is empty.
>>
>> Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>
>>     
>
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
>
>
>   

I confirmed that the OS level polling mode drivers still work properly
as well.

Jason.

Re: [Qemu-devel] [PATCH] fix serial IIR read [Was: SVN Rev 4994 (now) Won't install Windows XP]

[Anthony Liguori]

Samuel Thibault wrote:
> Brad Campbell, le Tue 12 Aug 2008 11:02:39 +0400, a écrit :
>   
>> qemu -hda xptest.img -cdrom XP-corp-sp2.iso -boot d -m 256 -no-kqemu 
>> -no-reboot -no-acpi
>>
>> It just hangs at "Setup is starting Windows".
>>     
>
> The patch below fixes it for me.
>   

Applied.  Thanks for fixing this so quickly.

Regards,

Anthony Liguori

> Samuel
>