Re: [Qemu-devel] [RFC, PATCH] Host AIO support detection, OpenBSD host support

[Anthony Liguori <anthony@codemonkey.ws>]

Blue Swirl wrote:
> Here are two patches, loosely based on patches in OpenBSD ports system
> that enable compiling Qemu. The first patch makes AIO use conditional
> on host AIO support. The second one adjusts various include files etc.
>
> I'd like to commit both of these, is that OK?
>   

The first patch is fine but the second patch has some bogus things in 
it.  For instance:
>
> Index: qemu/configure
> ===================================================================
> --- qemu.orig/configure    2008-08-12 17:12:15.000000000 +0000
> +++ qemu/configure    2008-08-12 17:33:36.000000000 +0000
> @@ -150,6 +150,7 @@
> @@ -1076,6 +1081,14 @@
>      echo "#define HAVE_BYTESWAP_H 1" >> $config_h
>    fi
>  fi
> +
> +if [ "$openbsd" = "yes" ] ; then
> +  echo "#define ENOTSUP 4096" >> $config_h
> +  echo "#define qemu_siginfo siginfo_t" >> $config_h
> +else
> +  echo "#define qemu_siginfo struct siginfo" >> $config_h
> +fi

But qemu_siginfo isn't actually used anywhere.  That's just one example, 
the patch seems to have a lot of things like this in it.

Regards,

Anthony Liguori