From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KSzqC-0007YL-JR
	for qemu-devel@nongnu.org; Tue, 12 Aug 2008 15:47:36 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KSzqA-0007Wk-A8
	for qemu-devel@nongnu.org; Tue, 12 Aug 2008 15:47:35 -0400
Received: from [199.232.76.173] (port=51192 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KSzqA-0007Wf-4W
	for qemu-devel@nongnu.org; Tue, 12 Aug 2008 15:47:34 -0400
Received: from wr-out-0506.google.com ([64.233.184.229]:30545)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KSzq9-0006ej-LA
	for qemu-devel@nongnu.org; Tue, 12 Aug 2008 15:47:33 -0400
Received: by wr-out-0506.google.com with SMTP id c46so2355447wra.18
	for <qemu-devel@nongnu.org>; Tue, 12 Aug 2008 12:47:31 -0700 (PDT)
Message-ID: <48A1E8AD.9040501@codemonkey.ws>
Date: Tue, 12 Aug 2008 14:46:53 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC, PATCH] Host AIO support detection, OpenBSD
	host support
References: <f43fc5580808121145u483ef7b8l6cb86165d259cf93@mail.gmail.com>
In-Reply-To: <f43fc5580808121145u483ef7b8l6cb86165d259cf93@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Blue Swirl wrote:
> Here are two patches, loosely based on patches in OpenBSD ports system
> that enable compiling Qemu. The first patch makes AIO use conditional
> on host AIO support. The second one adjusts various include files etc.
>
> I'd like to commit both of these, is that OK?
>   

The first patch is fine but the second patch has some bogus things in 
it.  For instance:
>
> Index: qemu/configure
> ===================================================================
> --- qemu.orig/configure    2008-08-12 17:12:15.000000000 +0000
> +++ qemu/configure    2008-08-12 17:33:36.000000000 +0000
> @@ -150,6 +150,7 @@
> @@ -1076,6 +1081,14 @@
>      echo "#define HAVE_BYTESWAP_H 1" >> $config_h
>    fi
>  fi
> +
> +if [ "$openbsd" = "yes" ] ; then
> +  echo "#define ENOTSUP 4096" >> $config_h
> +  echo "#define qemu_siginfo siginfo_t" >> $config_h
> +else
> +  echo "#define qemu_siginfo struct siginfo" >> $config_h
> +fi

But qemu_siginfo isn't actually used anywhere.  That's just one example, 
the patch seems to have a lot of things like this in it.

Regards,

Anthony Liguori