From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KTI7J-0007rK-22 for qemu-devel@nongnu.org; Wed, 13 Aug 2008 11:18:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KTI7H-0007qV-6H for qemu-devel@nongnu.org; Wed, 13 Aug 2008 11:18:28 -0400 Received: from [199.232.76.173] (port=40183 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KTI7G-0007qF-OJ for qemu-devel@nongnu.org; Wed, 13 Aug 2008 11:18:26 -0400 Received: from il.qumranet.com ([212.179.150.194]:20023) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KTI7G-0002JK-BN for qemu-devel@nongnu.org; Wed, 13 Aug 2008 11:18:26 -0400 Message-ID: <48A2FB3E.1020200@qumranet.com> Date: Wed, 13 Aug 2008 18:18:22 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Flush pending AIO on reboot and shutdown. References: <20080813132358.17672.68212.stgit@gleb-debian.qumranet.com.qumranet.com> <48A2E732.4040501@codemonkey.ws> <20080813141346.GC17567@minantech.com> <48A2F89A.20609@codemonkey.ws> In-Reply-To: <48A2F89A.20609@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Anthony Liguori wrote: >> I though about doing it this way, but then I saw that >> qemu_register_reset() >> is used for HW reset notification only. I don't think that hw/ide.c >> is the >> right place to register the notifier though, so I decided to call it >> explicitly. Do you think I should do qemu_register_reset() in block.c? >> > > But shouldn't the various disk types be the ones to flush their > outstanding IO on reset? Do you mean qemu block drivers, or disk controllers? -- error compiling committee.c: too many arguments to function