From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KTIaJ-0003MT-51
	for qemu-devel@nongnu.org; Wed, 13 Aug 2008 11:48:27 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KTIaH-0003MH-Jq
	for qemu-devel@nongnu.org; Wed, 13 Aug 2008 11:48:26 -0400
Received: from [199.232.76.173] (port=42046 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KTIaH-0003MD-EK
	for qemu-devel@nongnu.org; Wed, 13 Aug 2008 11:48:25 -0400
Received: from mail-gx0-f23.google.com ([209.85.217.23]:34515)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KTIaH-0003c4-3k
	for qemu-devel@nongnu.org; Wed, 13 Aug 2008 11:48:25 -0400
Received: by gxk4 with SMTP id 4so1280072gxk.10
	for <qemu-devel@nongnu.org>; Wed, 13 Aug 2008 08:48:23 -0700 (PDT)
Message-ID: <48A30220.1040705@codemonkey.ws>
Date: Wed, 13 Aug 2008 10:47:44 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Flush pending AIO on reboot and shutdown.
References: <20080813132358.17672.68212.stgit@gleb-debian.qumranet.com.qumranet.com>	<48A2E732.4040501@codemonkey.ws>	<20080813141346.GC17567@minantech.com>	<48A2F89A.20609@codemonkey.ws>
	<48A2FB3E.1020200@qumranet.com>
In-Reply-To: <48A2FB3E.1020200@qumranet.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Avi Kivity wrote:
> Anthony Liguori wrote:
>>> I though about doing it this way, but then I saw that 
>>> qemu_register_reset()
>>> is used for HW reset notification only. I don't think that hw/ide.c 
>>> is the
>>> right place to register the notifier though, so I decided to call it
>>> explicitly. Do you think I should do qemu_register_reset() in block.c?
>>>   
>>
>> But shouldn't the various disk types be the ones to flush their 
>> outstanding IO on reset?
>
> Do you mean qemu block drivers, or disk controllers?

The disk controllers.  It's a semantic of the disk controller itself 
(what happens on reset if there are outstanding requests).  Do those 
requests complete or are the cancelled?

Regards,

Anthony Liguori