qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Flush pending AIO on reboot and shutdown.
Date: Wed, 13 Aug 2008 21:40:34 +0300	[thread overview]
Message-ID: <48A32AA2.6030902@qumranet.com> (raw)
In-Reply-To: <20080813183544.GA29998@minantech.com>

Gleb Natapov wrote:
> but what bother me is that we
> consciously drop user data that we can easily save. Why? Real HW tries
> hard to save every bit of user data and we just decided to drop it. The
> difference between cancel or complete a request may be corrupted or not
> corrupted file system after a crash.
>
>   

If a guest didn't wait for an I/O to complete, it shouldn't expect it to 
be on disk.

Of course, we can have the IDE layer wait instead of cancelling, which 
will get the request onto the disk.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

  reply	other threads:[~2008-08-13 18:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-13 13:23 [Qemu-devel] [PATCH] Flush pending AIO on reboot and shutdown Gleb Natapov
2008-08-13 13:46 ` Samuel Thibault
2008-08-13 13:59   ` Gleb Natapov
2008-08-13 14:06     ` Samuel Thibault
2008-08-13 14:25       ` Gleb Natapov
2008-08-13 14:29         ` Samuel Thibault
2008-08-13 14:40           ` Avi Kivity
2008-08-13 14:41           ` Gleb Natapov
2008-08-13 16:14             ` Samuel Thibault
2008-08-13 13:52 ` Anthony Liguori
2008-08-13 14:13   ` Gleb Natapov
2008-08-13 15:07     ` Anthony Liguori
2008-08-13 15:18       ` Avi Kivity
2008-08-13 15:47         ` Anthony Liguori
2008-08-13 16:36           ` Avi Kivity
2008-08-13 15:23       ` Gleb Natapov
2008-08-13 15:53         ` Anthony Liguori
2008-08-13 18:35           ` Gleb Natapov
2008-08-13 18:40             ` Avi Kivity [this message]
2008-08-13 18:53               ` Gleb Natapov
2008-08-13 19:04                 ` Anthony Liguori
2008-08-14 10:26                   ` Jamie Lokier
2008-08-13 19:03             ` Anthony Liguori
2008-08-13 22:32               ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48A32AA2.6030902@qumranet.com \
    --to=avi@qumranet.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).