From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KTdXs-0006VE-04 for qemu-devel@nongnu.org; Thu, 14 Aug 2008 10:11:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KTdXp-0006US-08 for qemu-devel@nongnu.org; Thu, 14 Aug 2008 10:11:19 -0400 Received: from [199.232.76.173] (port=56771 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KTdXo-0006UN-Pz for qemu-devel@nongnu.org; Thu, 14 Aug 2008 10:11:16 -0400 Received: from ns.suse.de ([195.135.220.2]:35961 helo=mx1.suse.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KTdXo-0003Pk-HV for qemu-devel@nongnu.org; Thu, 14 Aug 2008 10:11:16 -0400 Message-ID: <48A43CCB.3030308@suse.de> Date: Thu, 14 Aug 2008 16:10:19 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <20080813145900.265987809@bull.net> <20080813145943.850512429@bull.net> In-Reply-To: <20080813145943.850512429@bull.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [patch 2/5][v3] Divide get_cluster_offset() Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent.Vivier@bull.net Cc: qemu-devel@nongnu.org Laurent.Vivier@bull.net schrieb: > Divide get_cluster_offset() into get_cluster_offset() and > alloc_cluster_offset(). > > Signed-off-by: Laurent Vivier > --- > block-qcow2.c | 208 ++++++++++++++++++++++++++++++++++++---------------------- > 1 file changed, 132 insertions(+), 76 deletions(-) The comment of get_cluster_offset describes a wrong return value. Otherwise Acked-by: Kevin Wolf