From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Cancel IDE outstanding IO on device reset.
Date: Thu, 14 Aug 2008 15:33:44 -0500 [thread overview]
Message-ID: <48A496A8.7060103@codemonkey.ws> (raw)
In-Reply-To: <20080814122437.5260.42952.stgit@gleb-debian.qumranet.com.qumranet.com>
Gleb Natapov wrote:
> Cancel AIO in IDE layer on device rest in order to be in deterministic state
> during next boot.
>
> -static void piix3_reset(PCIIDEState *d)
> +static void piix3_reset(void *opaque)
> {
> + PCIIDEState *d = opaque;
> uint8_t *pci_conf = d->dev.config;
> + int i;
> +
> + for (i = 0; i < 2; i++)
> + ide_dma_cancel(d->bmdma);
>
I think you intended:
ide_dma_cancel(&d->bmdma[i]);
Regards,
Anthony Liguori
next prev parent reply other threads:[~2008-08-14 20:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-14 12:24 [Qemu-devel] [PATCH] Cancel IDE outstanding IO on device reset Gleb Natapov
2008-08-14 20:33 ` Anthony Liguori [this message]
2008-08-15 5:38 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A496A8.7060103@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).