From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KTjWd-0003o1-KZ
	for qemu-devel@nongnu.org; Thu, 14 Aug 2008 16:34:27 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KTjWb-0003lA-2w
	for qemu-devel@nongnu.org; Thu, 14 Aug 2008 16:34:26 -0400
Received: from [199.232.76.173] (port=46535 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KTjWa-0003l3-Pt
	for qemu-devel@nongnu.org; Thu, 14 Aug 2008 16:34:24 -0400
Received: from wr-out-0506.google.com ([64.233.184.238]:31695)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KTjWa-0001FT-BE
	for qemu-devel@nongnu.org; Thu, 14 Aug 2008 16:34:24 -0400
Received: by wr-out-0506.google.com with SMTP id c46so800674wra.18
	for <qemu-devel@nongnu.org>; Thu, 14 Aug 2008 13:34:23 -0700 (PDT)
Message-ID: <48A496A8.7060103@codemonkey.ws>
Date: Thu, 14 Aug 2008 15:33:44 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Cancel IDE outstanding IO on device reset.
References: <20080814122437.5260.42952.stgit@gleb-debian.qumranet.com.qumranet.com>
In-Reply-To: <20080814122437.5260.42952.stgit@gleb-debian.qumranet.com.qumranet.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Gleb Natapov wrote:
> Cancel AIO in IDE layer on device rest in order to be in deterministic state
> during next boot.
>  
> -static void piix3_reset(PCIIDEState *d)
> +static void piix3_reset(void *opaque)
>  {
> +    PCIIDEState *d = opaque;
>      uint8_t *pci_conf = d->dev.config;
> +    int i;
> +
> +    for (i = 0; i < 2; i++)
> +        ide_dma_cancel(d->bmdma);
>   

I think you intended:

ide_dma_cancel(&d->bmdma[i]);

Regards,

Anthony Liguori