From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KUyr9-0006td-4d for qemu-devel@nongnu.org; Mon, 18 Aug 2008 03:08:47 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KUyr7-0006sn-HR for qemu-devel@nongnu.org; Mon, 18 Aug 2008 03:08:46 -0400 Received: from [199.232.76.173] (port=54449 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KUyr7-0006sk-Ax for qemu-devel@nongnu.org; Mon, 18 Aug 2008 03:08:45 -0400 Received: from mx20.gnu.org ([199.232.41.8]:44239) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KUyr7-00070J-BS for qemu-devel@nongnu.org; Mon, 18 Aug 2008 03:08:45 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KUyr5-0002ft-Dc for qemu-devel@nongnu.org; Mon, 18 Aug 2008 03:08:43 -0400 Received: from smtp06.web.de (fmsmtp06.dlan.cinetic.de [172.20.5.172]) by fmmailgate03.web.de (Postfix) with ESMTP id ECD25E6EEC71 for ; Mon, 18 Aug 2008 09:08:39 +0200 (CEST) Received: from [88.65.45.230] (helo=[192.168.1.198]) by smtp06.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.109 #226) id 1KUyr1-0001C6-00 for qemu-devel@nongnu.org; Mon, 18 Aug 2008 09:08:39 +0200 Message-ID: <48A91FF4.4070509@web.de> Date: Mon, 18 Aug 2008 09:08:36 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <484BED84.6070805@web.de> <4869D218.70008@web.de> <4879F856.3010609@web.de> In-Reply-To: <4879F856.3010609@web.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: jan.kiszka@web.de Subject: [Qemu-devel] [RESEND #3][PATCH] Report unmapped addresses in memory_dump Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Instead of dumping incorrect (ie. previously read) data, report the invalid virtual address to the user. Signed-off-by: Jan Kiszka --- monitor.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) Index: b/monitor.c =================================================================== --- a/monitor.c +++ b/monitor.c @@ -594,7 +594,10 @@ static void memory_dump(int count, int f env = mon_get_cpu(); if (!env) break; - cpu_memory_rw_debug(env, addr, buf, l, 0); + if (cpu_memory_rw_debug(env, addr, buf, l, 0) < 0) { + term_printf(" Cannot access memory\n"); + break; + } } i = 0; while (i < l) {