* [Qemu-devel] [PATCH] Report unmapped addresses in memory_dump
@ 2008-06-08 14:32 Jan Kiszka
2008-07-01 6:43 ` [Qemu-devel] [RESEND][PATCH] " Jan Kiszka
0 siblings, 1 reply; 5+ messages in thread
From: Jan Kiszka @ 2008-06-08 14:32 UTC (permalink / raw)
To: qemu-devel
Instead of dumping incorrect (ie. previously read) data, report the
invalid virtual address to the user.
Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
---
monitor.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
Index: b/monitor.c
===================================================================
--- a/monitor.c
+++ b/monitor.c
@@ -591,7 +591,10 @@ static void memory_dump(int count, int f
env = mon_get_cpu();
if (!env)
break;
- cpu_memory_rw_debug(env, addr, buf, l, 0);
+ if (cpu_memory_rw_debug(env, addr, buf, l, 0) < 0) {
+ term_printf(" Cannot access memory\n");
+ break;
+ }
}
i = 0;
while (i < l) {
^ permalink raw reply [flat|nested] 5+ messages in thread* [Qemu-devel] [RESEND][PATCH] Report unmapped addresses in memory_dump
2008-06-08 14:32 [Qemu-devel] [PATCH] Report unmapped addresses in memory_dump Jan Kiszka
@ 2008-07-01 6:43 ` Jan Kiszka
2008-07-13 12:43 ` [Qemu-devel] [RESEND #2][PATCH] " Jan Kiszka
0 siblings, 1 reply; 5+ messages in thread
From: Jan Kiszka @ 2008-07-01 6:43 UTC (permalink / raw)
To: qemu-devel
Instead of dumping incorrect (ie. previously read) data, report the
invalid virtual address to the user.
Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
---
monitor.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
Index: b/monitor.c
===================================================================
--- a/monitor.c
+++ b/monitor.c
@@ -596,7 +596,10 @@ static void memory_dump(int count, int f
env = mon_get_cpu();
if (!env)
break;
- cpu_memory_rw_debug(env, addr, buf, l, 0);
+ if (cpu_memory_rw_debug(env, addr, buf, l, 0) < 0) {
+ term_printf(" Cannot access memory\n");
+ break;
+ }
}
i = 0;
while (i < l) {
^ permalink raw reply [flat|nested] 5+ messages in thread* [Qemu-devel] [RESEND #2][PATCH] Report unmapped addresses in memory_dump
2008-07-01 6:43 ` [Qemu-devel] [RESEND][PATCH] " Jan Kiszka
@ 2008-07-13 12:43 ` Jan Kiszka
2008-08-18 7:08 ` [Qemu-devel] [RESEND #3][PATCH] " Jan Kiszka
0 siblings, 1 reply; 5+ messages in thread
From: Jan Kiszka @ 2008-07-13 12:43 UTC (permalink / raw)
To: qemu-devel
Instead of dumping incorrect (ie. previously read) data, report the
invalid virtual address to the user.
Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
---
monitor.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
Index: b/monitor.c
===================================================================
--- a/monitor.c
+++ b/monitor.c
@@ -596,7 +596,10 @@ static void memory_dump(int count, int f
env = mon_get_cpu();
if (!env)
break;
- cpu_memory_rw_debug(env, addr, buf, l, 0);
+ if (cpu_memory_rw_debug(env, addr, buf, l, 0) < 0) {
+ term_printf(" Cannot access memory\n");
+ break;
+ }
}
i = 0;
while (i < l) {
^ permalink raw reply [flat|nested] 5+ messages in thread* [Qemu-devel] [RESEND #3][PATCH] Report unmapped addresses in memory_dump
2008-07-13 12:43 ` [Qemu-devel] [RESEND #2][PATCH] " Jan Kiszka
@ 2008-08-18 7:08 ` Jan Kiszka
2008-08-18 14:01 ` Anthony Liguori
0 siblings, 1 reply; 5+ messages in thread
From: Jan Kiszka @ 2008-08-18 7:08 UTC (permalink / raw)
To: qemu-devel
Instead of dumping incorrect (ie. previously read) data, report the
invalid virtual address to the user.
Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
---
monitor.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
Index: b/monitor.c
===================================================================
--- a/monitor.c
+++ b/monitor.c
@@ -594,7 +594,10 @@ static void memory_dump(int count, int f
env = mon_get_cpu();
if (!env)
break;
- cpu_memory_rw_debug(env, addr, buf, l, 0);
+ if (cpu_memory_rw_debug(env, addr, buf, l, 0) < 0) {
+ term_printf(" Cannot access memory\n");
+ break;
+ }
}
i = 0;
while (i < l) {
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [RESEND #3][PATCH] Report unmapped addresses in memory_dump
2008-08-18 7:08 ` [Qemu-devel] [RESEND #3][PATCH] " Jan Kiszka
@ 2008-08-18 14:01 ` Anthony Liguori
0 siblings, 0 replies; 5+ messages in thread
From: Anthony Liguori @ 2008-08-18 14:01 UTC (permalink / raw)
To: qemu-devel
Jan Kiszka wrote:
> Instead of dumping incorrect (ie. previously read) data, report the
> invalid virtual address to the user.
>
Applied. Thanks.
Sorry it took three resends.
Regards,
Anthony Liguori
> Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
> ---
> monitor.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> Index: b/monitor.c
> ===================================================================
> --- a/monitor.c
> +++ b/monitor.c
> @@ -594,7 +594,10 @@ static void memory_dump(int count, int f
> env = mon_get_cpu();
> if (!env)
> break;
> - cpu_memory_rw_debug(env, addr, buf, l, 0);
> + if (cpu_memory_rw_debug(env, addr, buf, l, 0) < 0) {
> + term_printf(" Cannot access memory\n");
> + break;
> + }
> }
> i = 0;
> while (i < l) {
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-08-18 14:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-08 14:32 [Qemu-devel] [PATCH] Report unmapped addresses in memory_dump Jan Kiszka
2008-07-01 6:43 ` [Qemu-devel] [RESEND][PATCH] " Jan Kiszka
2008-07-13 12:43 ` [Qemu-devel] [RESEND #2][PATCH] " Jan Kiszka
2008-08-18 7:08 ` [Qemu-devel] [RESEND #3][PATCH] " Jan Kiszka
2008-08-18 14:01 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).