From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KV46w-0001Qd-Ay
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 08:45:26 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KV46s-0001QM-VH
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 08:45:26 -0400
Received: from [199.232.76.173] (port=36913 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KV46s-0001QJ-NB
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 08:45:22 -0400
Received: from mx1.redhat.com ([66.187.233.31]:51891)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1KV46s-0001qb-JN
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 08:45:22 -0400
Message-ID: <48A96ED4.7070604@redhat.com>
Date: Mon, 18 Aug 2008 14:45:08 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Xen-devel] Re: [Qemu-devel] [PATCH 00/11] merge some xen bits
	into qemu
References: <m2n.s.1KSWf2-002Qtv@chiark.greenend.org.uk>
	<18592.28557.41406.258988@mariner.uk.xensource.com>
	<48A09BEC.2040504@redhat.com>
	<20080815224142.GF5198@implementation>
In-Reply-To: <20080815224142.GF5198@implementation>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Samuel Thibault <samuel.thibault@eu.citrix.com>, Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org, xen-devel@lists.xensource.com

Samuel Thibault wrote:

> Well, maybe having a version of the patch that does not convert the code
> into the qemu identation would help a lot for on-list review.

Hmm, dunno how to do that best, git-format-patch seems to lack an
equivalent of "diff -b" ...

> Also, would it be possible to just have the backend core and
> console+framebuffer patches alone?  I don't see why we would need to
> change xen_machine_pv.c at all.

To stay closer to upstream?  Upstream xen_machine_pv.c will in the
future also have some bits to handle xen emulation which will never be
actually used when running on the xen hypervisor.  You don't really need
that.  But I think using the same source code it is a good idea
nevertheless, it will be less maintainance work long-term.

> That being said, I guess we should wait for a pull in the qemu-xen tree.

I'd prefer to not have a patch backlog with tons of unmerged stuff ...

cheers,
  Gerd

-- 
http://kraxel.fedorapeople.org/xenner/