From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KV5Im-0007s9-MB
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:01:44 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KV5Il-0007rA-D1
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:01:43 -0400
Received: from [199.232.76.173] (port=34074 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KV5Il-0007r3-7k
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:01:43 -0400
Received: from mail-gx0-f19.google.com ([209.85.217.19]:63202)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KV5Ik-000769-KX
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:01:42 -0400
Received: by gxk12 with SMTP id 12so3489844gxk.10
	for <qemu-devel@nongnu.org>; Mon, 18 Aug 2008 07:01:42 -0700 (PDT)
Message-ID: <48A9809C.4040108@codemonkey.ws>
Date: Mon, 18 Aug 2008 09:01:00 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RESEND #3][PATCH] Report unmapped addresses in
	memory_dump
References: <484BED84.6070805@web.de>
	<4869D218.70008@web.de>	<4879F856.3010609@web.de>
	<48A91FF4.4070509@web.de>
In-Reply-To: <48A91FF4.4070509@web.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Jan Kiszka wrote:
> Instead of dumping incorrect (ie. previously read) data, report the
> invalid virtual address to the user.
>   

Applied.  Thanks.

Sorry it took three resends.

Regards,

Anthony Liguori

> Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
> ---
>  monitor.c |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> Index: b/monitor.c
> ===================================================================
> --- a/monitor.c
> +++ b/monitor.c
> @@ -594,7 +594,10 @@ static void memory_dump(int count, int f
>              env = mon_get_cpu();
>              if (!env)
>                  break;
> -            cpu_memory_rw_debug(env, addr, buf, l, 0);
> +            if (cpu_memory_rw_debug(env, addr, buf, l, 0) < 0) {
> +                term_printf(" Cannot access memory\n");
> +                break;
> +            }
>          }
>          i = 0;
>          while (i < l) {
>
>
>