qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] pty/tty functions for BSD too
Date: Mon, 18 Aug 2008 09:06:41 -0500	[thread overview]
Message-ID: <48A981F1.6070606@codemonkey.ws> (raw)
In-Reply-To: <20080818105912.GF4686@implementation.uk.xensource.com>

Samuel Thibault wrote:
> Hello,
>
> In Xen, pty/tty functions are enabled for BSD too, shouldn't we enable
> them in upstream qemu too, as patched below?
>   

And you're sure that these functions compile/work on NetBSD/OpenBSD?  If 
so, we can enable them.

Regards,

Anthony Liguori

> Samuel
>
> Index: vl.c
> ===================================================================
> --- vl.c	(révision 5022)
> +++ vl.c	(copie de travail)
> @@ -2466,7 +2466,7 @@
>  }
>  #endif
>  
> -#if defined(__linux__) || defined(__sun__)
> +#if defined(__linux__) || defined(__sun__) || defined(__NetBSD__) || defined(__OpenBSD__)
>  
>  typedef struct {
>      int fd;
> @@ -3816,7 +3816,7 @@
>          return qemu_chr_open_pp(filename);
>      } else
>  #endif
> -#if defined(__linux__) || defined(__sun__)
> +#if defined(__linux__) || defined(__sun__) || defined(__NetBSD__) || defined(__OpenBSD__)
>      if (strstart(filename, "/dev/", NULL)) {
>          return qemu_chr_open_tty(filename);
>      } else
>
>
>   

  reply	other threads:[~2008-08-18 14:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-18 10:59 [Qemu-devel] pty/tty functions for BSD too Samuel Thibault
2008-08-18 14:06 ` Anthony Liguori [this message]
2008-08-18 14:23   ` Samuel Thibault
2008-08-18 15:12     ` Warner Losh
2008-08-18 17:18       ` Anthony Liguori
2008-08-18 16:16     ` Blue Swirl
2008-08-18 16:26       ` Daniel P. Berrange
2008-08-18 16:57         ` Blue Swirl
2008-08-18 18:08           ` Blue Swirl
2008-08-18 18:20             ` Daniel P. Berrange
2008-08-18 19:42             ` Jamie Lokier
2008-08-19 10:33             ` Bernhard Reutner-Fischer
2008-08-19 11:21               ` François Revol
2008-08-19 11:40                 ` Bernhard Reutner-Fischer
2008-08-19 12:55                   ` Samuel Thibault
2008-08-19 19:17                     ` Klaus Heinz
2008-08-21 18:16                       ` Blue Swirl
2008-08-19 12:35         ` Todd T. Fries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48A981F1.6070606@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).