From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KV5OG-0001me-Qp
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:07:24 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KV5OF-0001m6-9K
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:07:24 -0400
Received: from [199.232.76.173] (port=54587 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KV5OF-0001m3-6u
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:07:23 -0400
Received: from wr-out-0506.google.com ([64.233.184.228]:14769)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KV5OE-0000YD-RM
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:07:22 -0400
Received: by wr-out-0506.google.com with SMTP id c46so2912879wra.18
	for <qemu-devel@nongnu.org>; Mon, 18 Aug 2008 07:07:22 -0700 (PDT)
Message-ID: <48A981F1.6070606@codemonkey.ws>
Date: Mon, 18 Aug 2008 09:06:41 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] pty/tty functions for BSD too
References: <20080818105912.GF4686@implementation.uk.xensource.com>
In-Reply-To: <20080818105912.GF4686@implementation.uk.xensource.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Samuel Thibault wrote:
> Hello,
>
> In Xen, pty/tty functions are enabled for BSD too, shouldn't we enable
> them in upstream qemu too, as patched below?
>   

And you're sure that these functions compile/work on NetBSD/OpenBSD?  If 
so, we can enable them.

Regards,

Anthony Liguori

> Samuel
>
> Index: vl.c
> ===================================================================
> --- vl.c	(révision 5022)
> +++ vl.c	(copie de travail)
> @@ -2466,7 +2466,7 @@
>  }
>  #endif
>  
> -#if defined(__linux__) || defined(__sun__)
> +#if defined(__linux__) || defined(__sun__) || defined(__NetBSD__) || defined(__OpenBSD__)
>  
>  typedef struct {
>      int fd;
> @@ -3816,7 +3816,7 @@
>          return qemu_chr_open_pp(filename);
>      } else
>  #endif
> -#if defined(__linux__) || defined(__sun__)
> +#if defined(__linux__) || defined(__sun__) || defined(__NetBSD__) || defined(__OpenBSD__)
>      if (strstart(filename, "/dev/", NULL)) {
>          return qemu_chr_open_tty(filename);
>      } else
>
>
>