From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KV5RG-0002wv-19
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:10:30 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KV5RE-0002wQ-6w
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:10:29 -0400
Received: from [199.232.76.173] (port=34949 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KV5RE-0002wN-3c
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:10:28 -0400
Received: from qb-out-1314.google.com ([72.14.204.174]:6222)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KV5RD-0001V7-R1
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:10:27 -0400
Received: by qb-out-1314.google.com with SMTP id c6so2770093qbc.8
	for <qemu-devel@nongnu.org>; Mon, 18 Aug 2008 07:10:27 -0700 (PDT)
Message-ID: <48A982A8.4030800@codemonkey.ws>
Date: Mon, 18 Aug 2008 09:09:44 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Fix OpenBSD linker warnings
References: <f43fc5580808151320v6a0c40b2o2491f85d11196b35@mail.gmail.com>
In-Reply-To: <f43fc5580808151320v6a0c40b2o2491f85d11196b35@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Blue Swirl wrote:
> OpenBSD gcc issues warnings for some suspicious constructs, like:
> slirp/tcp_subr.c:1077: warning: Array size (256) smaller than format
> string size (257) (arg 3)
> vl.o(.text+0x7bc0): In function `drive_init':
> vl.c:5464: warning: strcpy() is almost always misused, please use strlcpy()
>
> This patch silences the warnings. Comments?
>   

Definitely a good thing.  strcpy()/sprintf() should never be used IMHO.

Regards,

Anthony Liguori