qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
	Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [Qemu-devel] [RESEND][PATCH] APIC: Do not start zero-period timers
Date: Mon, 18 Aug 2008 09:20:46 -0500	[thread overview]
Message-ID: <48A9853E.6090105@codemonkey.ws> (raw)
In-Reply-To: <48A698B4.2090203@web.de>

Jan Kiszka wrote:
> The APIC timer must not start when the initial count is (still) zero.
>
> This caused occasional stalls when booting secondary CPUs of Linux SMP
> guests.
>   

Applied.  Thanks.

Besides testing, I confirmed that this is what's done in the in-kernel 
APIC in KVM (which is also used by Xen).  It seems really unfortunate to 
me that there are fixes in the in-kernel APIC that aren't in QEMU (and 
perhaps vice-versa).  I wonder if there's any way to unify the two code 
bases?

Regards,

Anthony Liguori

  reply	other threads:[~2008-08-18 14:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-19  8:32 [Qemu-devel] [PATCH] APIC: Do not start zero-period timers Jan Kiszka
2008-08-16  9:07 ` [Qemu-devel] [RESEND][PATCH] " Jan Kiszka
2008-08-18 14:20   ` Anthony Liguori [this message]
2008-08-18 19:29     ` Asheesh Laroia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48A9853E.6090105@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=jan.kiszka@web.de \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).