From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KV5bu-0007uh-Ow
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:21:30 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KV5bs-0007th-Pg
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:21:29 -0400
Received: from [199.232.76.173] (port=41478 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KV5bs-0007tc-GC
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:21:28 -0400
Received: from wr-out-0506.google.com ([64.233.184.235]:18804)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KV5bs-0004rW-5f
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:21:28 -0400
Received: by wr-out-0506.google.com with SMTP id c46so2921818wra.18
	for <qemu-devel@nongnu.org>; Mon, 18 Aug 2008 07:21:27 -0700 (PDT)
Message-ID: <48A9853E.6090105@codemonkey.ws>
Date: Mon, 18 Aug 2008 09:20:46 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RESEND][PATCH] APIC: Do not start zero-period timers
References: <4881A6A5.1000603@web.de> <48A698B4.2090203@web.de>
In-Reply-To: <48A698B4.2090203@web.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>, Jan Kiszka <jan.kiszka@web.de>

Jan Kiszka wrote:
> The APIC timer must not start when the initial count is (still) zero.
>
> This caused occasional stalls when booting secondary CPUs of Linux SMP
> guests.
>   

Applied.  Thanks.

Besides testing, I confirmed that this is what's done in the in-kernel 
APIC in KVM (which is also used by Xen).  It seems really unfortunate to 
me that there are fixes in the in-kernel APIC that aren't in QEMU (and 
perhaps vice-versa).  I wonder if there's any way to unify the two code 
bases?

Regards,

Anthony Liguori