From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KV5mY-0007Ng-Ed
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:32:30 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KV5mV-0007Lm-Fi
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:32:29 -0400
Received: from [199.232.76.173] (port=53917 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KV5mV-0007Lj-CV
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:32:27 -0400
Received: from py-out-1112.google.com ([64.233.166.177]:30021)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KV5mU-0008Nt-Qg
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 10:32:27 -0400
Received: by py-out-1112.google.com with SMTP id p76so1645153pyb.10
	for <qemu-devel@nongnu.org>; Mon, 18 Aug 2008 07:32:25 -0700 (PDT)
Message-ID: <48A987CC.4040908@codemonkey.ws>
Date: Mon, 18 Aug 2008 09:31:40 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/3] [x86] Add Core 2 Duo CPU specification
References: <48A01655.3060604@suse.de>
In-Reply-To: <48A01655.3060604@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Alexander Graf <alex@csgraf.de>

Alexander Graf wrote:
> Hi,
>
> this set of patches attempts to implement a CPU definition set for 
> current Intel CPUs that resembles an original as closely as currently 
> possible. Several features a current Intel CPU has are not implemented 
> by qemu, but that should not keep us from adding this definition so 
> people can add features later on.
>
> As a side effect, I made the sysenter instruction 64-bit aware. This 
> was an issue in KVM, that used the 32-bit cpu struct variables to hold 
> 64-bit MSR  values sysenter needs. I believe it to be a step in the 
> right direction to not fix this only for KVM, but make the 
> functionality available to qemu as well.

Does anyone have any objections to this series?  I see no obvious flaws 
and it looks to be quite self contained.  My understanding is that this 
is needed to enable OS X guest support so it seems worthwhile to apply 
to me.

Regards,

Anthony Liguori

> Alex
>
>