From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KV92h-00024D-MK
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 14:01:23 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KV92g-00023D-FC
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 14:01:22 -0400
Received: from [199.232.76.173] (port=55425 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KV92f-000234-U3
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 14:01:21 -0400
Received: from py-out-1112.google.com ([64.233.166.183]:20023)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KV92f-0006v8-Fr
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 14:01:21 -0400
Received: by py-out-1112.google.com with SMTP id p76so1695538pyb.10
	for <qemu-devel@nongnu.org>; Mon, 18 Aug 2008 11:01:20 -0700 (PDT)
Message-ID: <48A9B8C6.60003@codemonkey.ws>
Date: Mon, 18 Aug 2008 13:00:38 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [RESEND #3][PATCH] i386: Catch all non-present
	ptes in cpu_get_phys_page_debug
References: <484BED67.7080007@web.de>	<4869D210.80904@web.de>	<4879F854.8070809@web.de>	<48A9200E.4070104@web.de>	<48A97FFC.3010002@codemonkey.ws>
	<48A99A30.5040708@web.de>
In-Reply-To: <48A99A30.5040708@web.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@web.de>

Jan Kiszka wrote:
> It helps debugging guests when yet unmapped pages are correctly reported
> as, well, unmapped.
>   

Applied.  Thanks.

Regards,

Anthony Liguori

> Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
> ---
>  target-i386/helper.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> Index: b/target-i386/helper.c
> ===================================================================
> --- a/target-i386/helper.c
> +++ b/target-i386/helper.c
> @@ -1192,6 +1192,8 @@ target_phys_addr_t cpu_get_phys_page_deb
>              page_size = 4096;
>              pte = ldq_phys(pte_addr);
>          }
> +        if (!(pte & PG_PRESENT_MASK))
> +            return -1;
>      } else {
>          uint32_t pde;
>  
>
>
>