From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KVpVE-0006VR-34 for qemu-devel@nongnu.org; Wed, 20 Aug 2008 11:21:40 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KVpVB-0006Tp-1f for qemu-devel@nongnu.org; Wed, 20 Aug 2008 11:21:38 -0400 Received: from [199.232.76.173] (port=34692 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KVpVA-0006Tc-Nv for qemu-devel@nongnu.org; Wed, 20 Aug 2008 11:21:36 -0400 Received: from mx20.gnu.org ([199.232.41.8]:22859) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KVpVA-0000hc-8n for qemu-devel@nongnu.org; Wed, 20 Aug 2008 11:21:36 -0400 Received: from lizzard.sbs.de ([194.138.37.39]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KVpV9-0007x4-5c for qemu-devel@nongnu.org; Wed, 20 Aug 2008 11:21:35 -0400 Received: from mail1.sbs.de (localhost [127.0.0.1]) by lizzard.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id m7KFLUP6023529 for ; Wed, 20 Aug 2008 17:21:30 +0200 Received: from [139.25.109.167] (mchn012c.mchp.siemens.de [139.25.109.167] (may be forged)) by mail1.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id m7KFLUq0002188 for ; Wed, 20 Aug 2008 17:21:30 +0200 Resent-To: qemu-devel@nongnu.org Resent-Message-Id: <48AC367B.1040606@siemens.com> Message-ID: <48AC30C7.60706@siemens.com> Date: Wed, 20 Aug 2008 16:57:11 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <486CF559.5090805@siemens.com> <48AC2E09.3030405@siemens.com> In-Reply-To: <48AC2E09.3030405@siemens.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [RESEND][PATCH 8/13] Remove premature memop TB terminations Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Now that we can properly restore the pc on watchpoint hits, there is no more need for prematurely terminating TBs if watchpoints are present. Remove all related bits. Signed-off-by: Jan Kiszka --- exec.c | 4 ---- target-arm/translate.c | 6 ------ target-m68k/translate.c | 6 ------ 3 files changed, 16 deletions(-) Index: b/exec.c =================================================================== --- a/exec.c +++ b/exec.c @@ -1277,10 +1277,6 @@ int cpu_watchpoint_insert(CPUState *env, env->watchpoints = wp; tlb_flush_page(env, addr); - /* FIXME: This flush is needed because of the hack to make memory ops - terminate the TB. It can be removed once the proper IO trap and - re-execute bits are in. */ - tb_flush(env); if (watchpoint) *watchpoint = wp; Index: b/target-arm/translate.c =================================================================== --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -8683,12 +8683,6 @@ static inline void gen_intermediate_code gen_set_label(dc->condlabel); dc->condjmp = 0; } - /* Terminate the TB on memory ops if watchpoints are present. */ - /* FIXME: This should be replacd by the deterministic execution - * IRQ raising bits. */ - if (dc->is_mem && env->watchpoints) - break; - /* Translation stops when a conditional branch is enoutered. * Otherwise the subsequent code could get translated several times. * Also stop translation when a page boundary is reached. This Index: b/target-m68k/translate.c =================================================================== --- a/target-m68k/translate.c +++ b/target-m68k/translate.c @@ -2979,12 +2979,6 @@ gen_intermediate_code_internal(CPUState dc->insn_pc = dc->pc; disas_m68k_insn(env, dc); num_insns++; - - /* Terminate the TB on memory ops if watchpoints are present. */ - /* FIXME: This should be replaced by the deterministic execution - * IRQ raising bits. */ - if (dc->is_mem && env->watchpoints) - break; } while (!dc->is_jmp && gen_opc_ptr < gen_opc_end && !env->singlestep_enabled && (pc_offset) < (TARGET_PAGE_SIZE - 32) &&