From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KWHej-0001PK-J2 for qemu-devel@nongnu.org; Thu, 21 Aug 2008 17:25:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KWHee-0001Mg-71 for qemu-devel@nongnu.org; Thu, 21 Aug 2008 17:25:21 -0400 Received: from [199.232.76.173] (port=42852 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KWHed-0001MK-Kq for qemu-devel@nongnu.org; Thu, 21 Aug 2008 17:25:15 -0400 Received: from mx1.redhat.com ([66.187.233.31]:34479) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KWHec-0003Lq-QG for qemu-devel@nongnu.org; Thu, 21 Aug 2008 17:25:15 -0400 Message-ID: <48ADDD31.7090701@redhat.com> Date: Thu, 21 Aug 2008 23:25:05 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1219336054-15919-1-git-send-email-kraxel@redhat.com> <1219336054-15919-13-git-send-email-kraxel@redhat.com> <20080821201708.GF1531@redhat.com> In-Reply-To: <20080821201708.GF1531@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [Xen-devel] [PATCH 12/13] set vnc password from xenstore. Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org Daniel P. Berrange wrote: > What is the justification for this change. We already have a means > to set the VNC password from the monitor. If this isn't sufficient > we should introduce an additional method which isn't Xen specific. Justification is that I've just implemented what qemu-dm does today, so upstream qemu can easily replace qemu-dm. I'm perfectly fine with dropping the patch altogether. > IMHO, XenD should just set the VNC password by connecting to the > monitor. That's what its there for after all. Agreed. cheers, Gerd