From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KWSvZ-0000vE-5F
	for qemu-devel@nongnu.org; Fri, 22 Aug 2008 05:27:29 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KWSvX-0000uJ-59
	for qemu-devel@nongnu.org; Fri, 22 Aug 2008 05:27:28 -0400
Received: from [199.232.76.173] (port=57196 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KWSvW-0000uC-Th
	for qemu-devel@nongnu.org; Fri, 22 Aug 2008 05:27:27 -0400
Received: from li2-213.members.linode.com ([69.56.173.213]:57090
	helo=mail.zilogic.com) by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <vijaykumar@bravegnu.org>) id 1KWSvW-0006oC-SS
	for qemu-devel@nongnu.org; Fri, 22 Aug 2008 05:27:27 -0400
Received: from [172.16.253.237] (unknown [122.164.74.52])
	by mail.zilogic.com (Postfix) with ESMTP id E0E3A1055F
	for <qemu-devel@nongnu.org>; Fri, 22 Aug 2008 05:27:22 -0400 (EDT)
Message-ID: <48AE881E.4060202@bravegnu.org>
Date: Fri, 22 Aug 2008 15:04:22 +0530
From: Vijay Kumar <vijaykumar@bravegnu.org>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [5063] Parallel Port Direction Fix
References: <E1KWSSE-0004w1-J3@cvs.savannah.gnu.org>
In-Reply-To: <E1KWSSE-0004w1-J3@cvs.savannah.gnu.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Aurelien Jarno wrote:
> Modified: trunk/qemu-char.h
> ===================================================================
> --- trunk/qemu-char.h	2008-08-21 23:03:15 UTC (rev 5062)
> +++ trunk/qemu-char.h	2008-08-22 08:57:09 UTC (rev 5063)
> @@ -27,6 +27,7 @@
>  #define CHR_IOCTL_PP_EPP_READ         9
>  #define CHR_IOCTL_PP_EPP_WRITE_ADDR  10
>  #define CHR_IOCTL_PP_EPP_WRITE       11
> +#define CHR_IOCTL_PP_DATA_DIR        12
>  
>  #define CHR_IOCTL_SERIAL_SET_TIOCM   12
>  #define CHR_IOCTL_SERIAL_GET_TIOCM   13

Jarno, thanks for committing the patch. But it seems that now there are two IOCTL macros with the same value. To be safe we can move CHR_IOCTL_PP_DATA_DIR to 14.

Signed-off-by: Vijay Kumar <vijaykumar@bravegnu.org>

Index: qemu/qemu-char.h
===================================================================
--- qemu.orig/qemu-char.h	2008-08-22 15:02:12.000000000 +0530
+++ qemu/qemu-char.h	2008-08-22 15:02:16.000000000 +0530
@@ -27,11 +27,12 @@
 #define CHR_IOCTL_PP_EPP_READ         9
 #define CHR_IOCTL_PP_EPP_WRITE_ADDR  10
 #define CHR_IOCTL_PP_EPP_WRITE       11
-#define CHR_IOCTL_PP_DATA_DIR        12
 
 #define CHR_IOCTL_SERIAL_SET_TIOCM   12
 #define CHR_IOCTL_SERIAL_GET_TIOCM   13
 
+#define CHR_IOCTL_PP_DATA_DIR        14
+
 #define CHR_TIOCM_CTS	0x020
 #define CHR_TIOCM_CAR	0x040
 #define CHR_TIOCM_DSR	0x100